Add new option for Erroring when variable is missing#59
Open
schotime wants to merge 1 commit intomikebridge:masterfrom
Open
Add new option for Erroring when variable is missing#59schotime wants to merge 1 commit intomikebridge:masterfrom
schotime wants to merge 1 commit intomikebridge:masterfrom
Conversation
Current coverage is
|
Owner
|
Thanks, I'll have a few minutes to look at it over the next day or so. |
Author
|
HI @mikebridge |
Owner
gabrielsadaka
force-pushed
the
split_errors_by_variable_and_value
branch
from
e914091 to
1568da7
Compare
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=========================================
- Coverage 0.02% 0.02% -0.01%
=========================================
Files 140 140
Lines 4922 4939 +17
Branches 453 456 +3
=========================================
Hits 1 1
- Misses 4921 4938 +17
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the erroring so that if the variable doesn't exist, it gives a different error from when the value is undefined. I've added a new option so you can turn either on.
Let me know what you think.